Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple scaling modifications #2666

Merged
merged 24 commits into from
Sep 19, 2023
Merged

Multiple scaling modifications #2666

merged 24 commits into from
Sep 19, 2023

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented Aug 7, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

New feature

What is the current behavior?

What is the new behavior (if this is a feature change)?
Allow the user to easily scale a power variation on a group of load or generators using different kind of distributions

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

rolnico added 2 commits August 4, 2023 11:33
@rolnico
Implementation of ProportionalScalable on loads and on generators
162fac8 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
Implementation of ProportionalScalable on loads and on generators
2488883 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico rolnico requested a review from colinepiloquet August 7, 2023 08:30
@rolnico rolnico self-assigned this Aug 7, 2023
@rolnico rolnico marked this pull request as draft August 7, 2023 08:55
rolnico added 2 commits August 7, 2023 12:45
@rolnico
Merge VariationParameters into existing ScalingParameters + make scal…
d37ac44 
…eOnX methods static

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
Added Exceptions management and Tests
aae0a7d 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
colinepiloquet
colinepiloquet reviewed Aug 8, 2023
View reviewed changes
...idm-modification/src/main/java/com/powsybl/iidm/modification/scalable/ScalingParameters.java Outdated Show resolved Hide resolved
...ification/src/test/java/com/powsybl/iidm/modification/scalable/ProportionalScalableTest.java
/*
* Copyright (c) 2023. , All partners of the iTesla project (http://www.itesla-project.eu/consortium)
* This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed with this file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here there should also be the license id: SPDX-License-Identifier: MPL-2.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the licence header is not the one to use. The European iTesla project no longer exists (it ended in 2016).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why this one was configured, I switch it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 2023 + license ID

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified

rolnico and others added 5 commits August 8, 2023 17:57
@rolnico
Moved scaleOnLoads and scaleOnGenerators in Scalable, added STACKING_…
f45a773 
…UP mode, added priorities

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
Modified and moved the reporter, added a default value for a paramete…
d957c35 
…r, added a test on the depreciated methods

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
Added tests for coverage
4a40f89 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
Added tests for coverage
f51a09c 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@annetill
Merge branch 'main' into multiple_scaling_modifications
b298cad
phiedw
phiedw reviewed Aug 30, 2023
View reviewed changes
...idm-modification/src/main/java/com/powsybl/iidm/modification/scalable/ScalingParameters.java Outdated Show resolved Hide resolved
...idm-modification/src/main/java/com/powsybl/iidm/modification/scalable/ScalingParameters.java Outdated Show resolved Hide resolved
iidm/iidm-modification/src/main/java/com/powsybl/iidm/modification/scalable/Scalable.java Outdated Show resolved Hide resolved
...-modification/src/main/java/com/powsybl/iidm/modification/scalable/ProportionalScalable.java Outdated Show resolved Hide resolved
...idm-modification/src/main/java/com/powsybl/iidm/modification/scalable/GeneratorScalable.java Outdated Show resolved Hide resolved
iidm/iidm-modification/src/main/java/com/powsybl/iidm/modification/scalable/Scalable.java Outdated Show resolved Hide resolved
iidm/iidm-modification/src/main/java/com/powsybl/iidm/modification/scalable/Scalable.java Outdated Show resolved Hide resolved
@phiedw
create proportional and then scale rather than having a method doing …
1134ed2 
…both

Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
@phiedw
removed scalingValue from ScalingParameters
b3b2489 
Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
@rolnico
Reorganized code for Scalables
794eb69 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
Checkstyle corrections
ce4410a 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
Correction of testProportional (float to double)
e91acea 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
phiedw
phiedw reviewed Sep 11, 2023
View reviewed changes
...-modification/src/main/java/com/powsybl/iidm/modification/scalable/ProportionalScalable.java Outdated Show resolved Hide resolved
...-modification/src/main/java/com/powsybl/iidm/modification/scalable/ProportionalScalable.java Show resolved Hide resolved
...-modification/src/main/java/com/powsybl/iidm/modification/scalable/ProportionalScalable.java Outdated Show resolved Hide resolved
...-modification/src/main/java/com/powsybl/iidm/modification/scalable/ProportionalScalable.java Outdated Show resolved Hide resolved
...-modification/src/main/java/com/powsybl/iidm/modification/scalable/ProportionalScalable.java Outdated Show resolved Hide resolved
...-modification/src/main/java/com/powsybl/iidm/modification/scalable/ProportionalScalable.java Outdated Show resolved Hide resolved
...-modification/src/main/java/com/powsybl/iidm/modification/scalable/ProportionalScalable.java Outdated Show resolved Hide resolved
iidm/iidm-modification/src/main/java/com/powsybl/iidm/modification/scalable/Scalable.java Outdated Show resolved Hide resolved
.../iidm-modification/src/main/java/com/powsybl/iidm/modification/scalable/ScalableAdapter.java Outdated Show resolved Hide resolved
iidm/iidm-modification/src/main/java/com/powsybl/iidm/modification/scalable/StackScalable.java Outdated Show resolved Hide resolved
@rolnico
deletion of checkPositiveAskedWhenTarget and modification of getCurre…
bd21317 
…ntPower

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico rolnico marked this pull request as ready for review September 13, 2023 09:59
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

95.7% 95.7% Coverage
0.0% 0.0% Duplication

@rolnico
Javadoc corrected
922a004 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@annetill annetill merged commit 75dadba into main Sep 19, 2023
@annetill annetill deleted the multiple_scaling_modifications branch September 19, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olperr1 olperr1 olperr1 left review comments

@geofjamg geofjamg geofjamg left review comments

@colinepiloquet colinepiloquet colinepiloquet approved these changes

@annetill annetill annetill approved these changes

@phiedw phiedw phiedw approved these changes

Assignees

@rolnico rolnico

Labels
PR: next-release PR: ready-to-be-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rolnico @geofjamg @phiedw @olperr1 @annetill @colinepiloquet